WIP v0.5.0-rc.2 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't have an explanation why the rust std print macros panic, but this fixes rwf2#2019 Tested with and without redirecting. Log output looks like usual.
needs secure feature for signed and private cookies
Fixes rwf2#2063 In cookies::CookieJar::get_private_pending() is no decrypt of pending cookie possible, because pending cookies are just operated before server sends response and so cookies are not yet encrypted. Just return the cookie as it is.
Dependency multer -> spin doesn't build below rust 1.51.0 which seems to be related to * atomic::spin_loop_hint has been deprecated. It's recommended to use hint::spin_loop instead.
resolving fails below because of crate time
cargo resolving fails below because of crate time
Testing combination of non-private/private cookies and if private ones get en- and decrypted.
Documentation and Site must be done later.
fix(log): implement print macros without panic
fix: CookieJar::get_private_pending() rwf2#2063
There will be some dep updates
Hides an unused warning. Added a TODO comment because it is not clear what might be the purpose of the field.
the output messages differ between stable and msrv
digitwolf
reviewed
Jan 24, 2022
| @@ -119,6 +117,7 @@ impl Poolable for diesel::SqliteConnection { | |||
| type Error = std::convert::Infallible; | |||
|
|
|||
| fn pool(db_name: &str, rocket: &Rocket<Build>) -> PoolResult<Self> { | |||
| use std::time::Duration; | |||
There was a problem hiding this comment.
Why are you moving the use statement?
There was a problem hiding this comment.
Unused depending on feature compilation
digitwolf
reviewed
Jan 25, 2022
| BuildError::Backend(e) => Error::Init(e), | ||
| BuildError::NoRuntimeSpecified(e_msg) => { | ||
| // it is set above in builder, so panic here | ||
| panic!("init failed to set runtime: {}", e_msg) |
There was a problem hiding this comment.
This may result in poor user-experience.
If crashing is the only option - it would be nice to at least explain to the user what is missing and how to fix it.
There was a problem hiding this comment.
No it will not because this can only happen if we had forgot to set the runtime above.
* Metadata is pub(crate) * derive Debug, Clone is at the moment not used * field query_segs is only written, but not read
* unused cleaned up * paths changed in output * compiler messages changed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is based on the earlier PRs and it is NOT intended for NOW being merged...
Just to follow what is going on...
You can give me in comments some hints for what is ready to be pulled from other PRs!
My intention is to continue with these next steps...
2, 3 and 4 in some round-robin fashion.
Always welcome are updates to website and documentation. My mother language is not English and so I would maybe produce some amusement and obscurities. ;-)